linux-kernel - Re: [PATCH] x86/mce: Remove redundant irq work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1907301042190.1738@nanos.tec.linutronix.de>
Date:   Tue, 30 Jul 2019 10:44:34 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Santosh Sivaraj <santosh@...six.org>
cc:     x86@...nel.org, Linux Kernel <linux-kernel@...r.kernel.org>,
        "H. Peter Anvin" <hpa@...or.com>,
        "Aneesh Kumar K.V" <aneesh.kumar@...ux.ibm.com>
Subject: Re: [PATCH] x86/mce: Remove redundant irq work

On Tue, 30 Jul 2019, Santosh Sivaraj wrote:

> IRQ work currently only does a schedule work to process the mce
> events. Since irq work does no other function, remove it.

No. You _cannot call schedule_work() from MCE exception context as MCE can
interrupt even interrupt disabled context similar to NMI. irq work is
designed to work in those contexts.

Thanks,

	tglx