linux-kernel - Re: [PATCH v4] platform/chrome: cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+Px+wXetT1mQZW+3zc2vNDP4Jf3zKqGNz=Hq0yHn0Fvf=y-FQ@mail.gmail.com>
Date:   Tue, 30 Jul 2019 22:07:35 +0800
From:   Tzung-Bi Shih <tzungbi@...gle.com>
To:     bleung@...omium.org, enric.balletbo@...labora.com,
        groeck@...omium.org, rrangel@...omium.org
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jimmy Cheng-Yi Chiang <cychiang@...gle.com>,
        Dylan Reid <dgreid@...gle.com>,
        Tzung-Bi Shih <tzungbi@...gle.com>
Subject: Re: [PATCH v4] platform/chrome: cros_ec_trace: update generating script

Hi Enric,

I found it is error-prone to replace the EC_CMDS after updated.
Perhaps, we should introduce an intermediate file "cros_ec_trace.inc".
The generating script replaces whole ".inc" file every time and the
cros_ec_trace.c includes the "cros_ec_trace.inc".

If this proposal makes sense to you, I can send the patch after this
change landed for*-next.