linux-kernel - Re: [PATCH v4] platform/chrome: cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <106711f8-117a-d0df-9b66-dc6be6431d07@collabora.com>
Date:   Thu, 1 Aug 2019 12:59:23 +0200
From:   Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:     Tzung-Bi Shih <tzungbi@...gle.com>, bleung@...omium.org,
        groeck@...omium.org, rrangel@...omium.org
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jimmy Cheng-Yi Chiang <cychiang@...gle.com>,
        Dylan Reid <dgreid@...gle.com>
Subject: Re: [PATCH v4] platform/chrome: cros_ec_trace: update generating
 script

Hi Tzung-Bi

On 30/7/19 16:07, Tzung-Bi Shih wrote:
> Hi Enric,
> 
> I found it is error-prone to replace the EC_CMDS after updated.
> Perhaps, we should introduce an intermediate file "cros_ec_trace.inc".

I am not sure I get you here, a .inc? could you explain a bit more?

Thanks,
~ Enric

> The generating script replaces whole ".inc" file every time and the
> cros_ec_trace.c includes the "cros_ec_trace.inc".
> 
> If this proposal makes sense to you, I can send the patch after this
> change landed for*-next.
>