linux-kernel - Re: [PATCH v4] platform/chrome: cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+Px+wU=V0cGZeAxoqSJeVTLcO+v9=tPQKxKBTp-npsgqXo3yQ@mail.gmail.com>
Date:   Thu, 1 Aug 2019 21:04:04 +0800
From:   Tzung-Bi Shih <tzungbi@...gle.com>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>
Cc:     bleung@...omium.org, groeck@...omium.org, rrangel@...omium.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jimmy Cheng-Yi Chiang <cychiang@...gle.com>,
        Dylan Reid <dgreid@...gle.com>
Subject: Re: [PATCH v4] platform/chrome: cros_ec_trace: update generating script

On Thu, Aug 1, 2019 at 6:59 PM Enric Balletbo i Serra
<enric.balletbo@...labora.com> wrote:
>
> Hi Tzung-Bi
>
> On 30/7/19 16:07, Tzung-Bi Shih wrote:
> > Hi Enric,
> >
> > I found it is error-prone to replace the EC_CMDS after updated.
> > Perhaps, we should introduce an intermediate file "cros_ec_trace.inc".
>
> I am not sure I get you here, a .inc? could you explain a bit more?
>
Manually generate .inc for all EC host commands:
sed ... include/linux/mfd/cros_ec_commands.h | awk ...
>drivers/platform/chrome/cros_ec_trace.inc

In cros_ec_trace.c:
#include "cros_ec_trace.inc"

cros_ec_trace.inc:
#ifndef EC_CMDS
#define EC_CMDS \
    ...
#endif

Override the whole file instead of replacing part of file to prevent
cut-and-paste error.