linux-kernel - Re: [PATCH 1/3] KVM: Don't need to wakeup vCPU twice afer timer fire

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a3c6d25e-8ede-695d-8f2d-632799c5fb1c@redhat.com>
Date:   Wed, 31 Jul 2019 18:39:59 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <kernellwp@...il.com>
Cc:     Radim Krčmář <rkrcmar@...hat.com>,
        linux-kernel@...r.kernel.org, kvm@...r.kernel.org
Subject: Re: [PATCH 1/3] KVM: Don't need to wakeup vCPU twice afer timer fire

On 31/07/19 15:14, Vitaly Kuznetsov wrote:
> Paolo Bonzini <pbonzini@...hat.com> writes:
> 
>> On 31/07/19 13:27, Wanpeng Li wrote:
>>> From: Wanpeng Li <wanpengli@...cent.com>
>>>
>>> kvm_set_pending_timer() will take care to wake up the sleeping vCPU which 
>>> has pending timer, don't need to check this in apic_timer_expired() again.
>>
>> No, it doesn't.  kvm_make_request never kicks the vCPU.
>>
> 
> Hm, but kvm_set_pending_timer() currently looks like:
> 
> void kvm_set_pending_timer(struct kvm_vcpu *vcpu)
> {
> 	kvm_make_request(KVM_REQ_PENDING_TIMER, vcpu);
> 	kvm_vcpu_kick(vcpu);
> }

Doing "git fetch" could have helped indeed.

Paolo