linux-kernel - Re: [PATCH v3] staging: rtl8192u: null check the kzalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190731113642.GA3983@kroah.com>
Date:   Wed, 31 Jul 2019 13:36:42 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Navid Emamdoost <navid.emamdoost@...il.com>
Cc:     devel@...verdev.osuosl.org, b.zolnierkie@...sung.com, kjlu@....edu,
        linux-kernel@...r.kernel.org,
        John Whitmore <johnfwhitmore@...il.com>, emamd001@....edu,
        Nishka Dasgupta <nishkadg.linux@...il.com>, smccaman@....edu,
        Colin Ian King <colin.king@...onical.com>
Subject: Re: [PATCH v3] staging: rtl8192u: null check the kzalloc

On Tue, Jul 30, 2019 at 05:01:39PM -0500, Navid Emamdoost wrote:
> In rtl8192_init_priv_variable allocation for priv->pFirmware may fail,
> so a null check is necessary.priv->pFirmware is accessed later in
> rtl8192_adapter_start. I added the check and made appropriate changes
> to propagate the errno to the caller.
> 
> ---
> Update v2: fixed style errors
> Update V3: fixed prefix
> 
> Signed-off-by: Navid Emamdoost <navid.emamdoost@...il.com>

So close, the signed-off-by goes above the --- line.

thanks,

greg k-h