linux-kernel - Re: [PATCH 14/22] ARM: dts: apalis-imx6: Add some example I2C devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd35b9553397f51153ccb5cea9205f91f659cfdf.camel@toradex.com>
Date:   Wed, 31 Jul 2019 11:36:59 +0000
From:   Philippe Schenker <philippe.schenker@...adex.com>
To:     "festevam@...il.com" <festevam@...il.com>
CC:     "stefan@...er.ch" <stefan@...er.ch>,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        Max Krummenacher <max.krummenacher@...adex.com>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "linux-imx@....com" <linux-imx@....com>
Subject: Re: [PATCH 14/22] ARM: dts: apalis-imx6: Add some example I2C devices

On Tue, 2019-07-30 at 17:53 -0300, Fabio Estevam wrote:
> On Tue, Jul 30, 2019 at 11:57 AM Philippe Schenker <dev@...henker.ch> wrote:
> 
> >  &backlight {
> > @@ -204,6 +228,77 @@
> >   */
> >  &i2c3 {
> >         status = "okay";
> > +
> > +       adv7280: adv7280@21 {
> > +               compatible = "adv7280";
> > +               reg = <0x21>;
> > +               pinctrl-names = "default";
> > +               pinctrl-0 = <&pinctrl_ipu1_csi0 &pinctrl_cam_mclk>;
> > +               clocks = <&clks 200>;
> 
> Please replace this 200 with a proper clock label.
> 
> > +               clock-names = "csi_mclk";
> > +               DOVDD-supply = <&reg_3p3v>;
> > +               AVDD-supply = <&reg_3p3v>;
> > +               DVDD-supply = <&reg_3p3v>;
> > +               PVDD-supply = <&reg_3p3v>;
> > +               csi_id = <0>;
> 
> This is not a valid property upstream.
> 
> It seems you just ported it from a downstream vendor kernel. Please
> make sure you test with the dt-bindings from mainline.
> 
> > +               mclk = <24000000>;
> > +               mclk_source = <1>;
> > +               status = "okay";
> > +       };
> > +
> > +       /* Video ADC on Analog Camera Module */
> > +       adv7180: adv7180@21 {
> > +               compatible = "adv,adv7180";
> > +               reg = <0x21>;
> > +               pinctrl-names = "default";
> > +               pinctrl-0 = <&pinctrl_ipu1_csi0 &pinctrl_cam_mclk>;
> > +               clocks = <&clks 200>;
> 
> clock label, please.
> 
> > +               clock-names = "csi_mclk";
> > +               DOVDD-supply = <&reg_3p3v>; /* 3.3v */
> > +               AVDD-supply = <&reg_3p3v>;  /* 1.8v */
> > +               DVDD-supply = <&reg_3p3v>;  /* 1.8v */
> > +               PVDD-supply = <&reg_3p3v>;  /* 1.8v */
> > +               csi_id = <0>;
> 
> Same here
> 
> > +               mclk = <24000000>;
> > +               mclk_source = <1>;
> > +               cvbs = <1>;
> > +               status = "disabled";
> > +       };
> > +
> > +       max9526: max9526@20 {
> > +               compatible = "maxim,max9526";
> 
> This is not documented in mainline.

Yeah, too much downstream stuff in here. I will drop that patch for now...