linux-kernel - Re: [PATCH v3 7/7] habanalabs: create two char devices per ASIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190731130223.GB7590@kroah.com>
Date:   Wed, 31 Jul 2019 15:02:23 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Oded Gabbay <oded.gabbay@...il.com>
Cc:     linux-kernel@...r.kernel.org, oshpigelman@...ana.ai,
        ttayar@...ana.ai
Subject: Re: [PATCH v3 7/7] habanalabs: create two char devices per ASIC

On Wed, Jul 31, 2019 at 03:59:01PM +0300, Oded Gabbay wrote:
> This patch changes the driver to create two char devices for each ASIC
> it discovers. This is done to allow system/monitoring applications to
> query the device for stats, information, idle state and more, while also
> allowing the deep-learning application to send work to the ASIC.
> 
> One char device is the original device, hlX. IOCTL calls through this
> device file can perform any task on the device (compute, memory, queries).
> The open function for this device will fail if it was called before but
> the file-descriptor it created was not completely released yet (the
> release callback function is not called from the kernel until all
> instances of that FD are closed). The driver needs to keep this behavior
> to support backward compatibility with existing userspace, which count
> that the open will fail if the device is "occupied".
> 
> The second char device is called "hl_controlDx", where x is the same index
> of the main device with a minor number of the original char device + 1.
> Applications that open this device can only call the INFO IOCTL. There is
> no limitation on the number of applications opening this device.
> 
> Signed-off-by: Oded Gabbay <oded.gabbay@...il.com>

Looks good, thanks for changing the minor allocation:

Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>