linux-kernel - Re: [PATCH v3 0/7] habanalabs: support info queries by multiple processes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190731130241.GC7590@kroah.com>
Date:   Wed, 31 Jul 2019 15:02:41 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Oded Gabbay <oded.gabbay@...il.com>
Cc:     linux-kernel@...r.kernel.org, oshpigelman@...ana.ai,
        ttayar@...ana.ai
Subject: Re: [PATCH v3 0/7] habanalabs: support info queries by multiple
 processes

On Wed, Jul 31, 2019 at 03:58:54PM +0300, Oded Gabbay wrote:
> v3 introduces a few fixes and changes the control char device's minor
> number to be 1 above that of the main device.
> 
> Original text:
> 
> Today, the driver allows only a single user application (the deep-learning
> application) to perform queries of the device's stats, information, idle
> state and more.
> 
> This is a serious limitation in data centers, where there are
> multiple system/monitorining applications that want to continuously
> retrieve that information, while allowing the deep-learning application to
> perform work on the device.
> 
> This patch-set allows unlimited number of user applications to perform
> the above queries (by calling the INFO IOCTL), while the deep-learning
> application is running.
> 
> This is done by creating an additional char device per ASIC, that is
> dedicated to information retrieval only (allows only to call the INFO
> IOCTL). This method will maintain backward compatibility with existing
> userspace applications.
> 
> - Patches 1-4 makes small improvements to existing code.
> - Patch 5 removes the accounting of the number of open file-descriptors
>   and replace it with tracking of the driver's internal file private data
>   strcuture.
> - Patch 6 is a pre-requisite to creating the two char devices
> - Patch 7 introduce the additional char device
> 
> Thanks,
> Oded
> 
> Oded Gabbay (7):
>   habanalabs: add handle field to context structure
>   habanalabs: kill user process after CS rollback
>   habanalabs: show the process context dram usage
>   habanalabs: rename user_ctx as compute_ctx
>   habanalabs: maintain a list of file private data objects
>   habanalabs: change device_setup_cdev() to be more generic
>   habanalabs: create two char devices per ASIC

Whole series is:

Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>