linux-kernel - Re: [PATCH v2] kconfig: Clear "written" flag to avoid data loss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNAS3heQA-0FzANyqXGSOR+kZ6zLgoSWYEW_ngrEdH46QsQ@mail.gmail.com>
Date:   Sun, 4 Aug 2019 12:50:10 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     "M. Vefa Bicakci" <m.v.b@...box.com>
Cc:     Joonas Kylmälä <joonas.kylmala@....fi>,
        Ulf Magnusson <ulfalizer@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        linux-stable <stable@...r.kernel.org>
Subject: Re: [PATCH v2] kconfig: Clear "written" flag to avoid data loss

On Sat, Aug 3, 2019 at 7:02 PM M. Vefa Bicakci <m.v.b@...box.com> wrote:
>
> Prior to this commit, starting nconfig, xconfig or gconfig, and saving
> the .config file more than once caused data loss, where a .config file
> that contained only comments would be written to disk starting from the
> second save operation.
>
> This bug manifests itself because the SYMBOL_WRITTEN flag is never
> cleared after the first call to conf_write, and subsequent calls to
> conf_write then skip all of the configuration symbols due to the
> SYMBOL_WRITTEN flag being set.
>
> This commit resolves this issue by clearing the SYMBOL_WRITTEN flag
> from all symbols before conf_write returns.
>
> Fixes: 8e2442a5f86e ("kconfig: fix missing choice values in auto.conf")
> Cc: linux-stable <stable@...r.kernel.org> # 4.19+
> Signed-off-by: M. Vefa Bicakci <m.v.b@...box.com>


Applied to linux-kbuild/fixes.
Thanks.



-- 
Best Regards
Masahiro Yamada