linux-kernel - Re: [PATCH] phy: qualcomm: phy-qcom-qmp: Add of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFp+6iE0BN9+BA-9hozs0-0LDCA+-LLZPdZfebaRAi9nTRV4xg@mail.gmail.com>
Date:   Mon, 5 Aug 2019 11:36:41 +0530
From:   Vivek Gautam <vivek.gautam@...eaurora.org>
To:     Nishka Dasgupta <nishkadg.linux@...il.com>
Cc:     Andy Gross <agross@...nel.org>, kishon <kishon@...com>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] phy: qualcomm: phy-qcom-qmp: Add of_node_put() before return

On Sun, Aug 4, 2019 at 9:54 PM Nishka Dasgupta <nishkadg.linux@...il.com> wrote:
>
> Each iteration of for_each_available_child_of_node puts the previous
> node, but in the case of a return from the middle of the loop, there is
> no put, thus causing a memory leak. Hence add an of_node_put before the
> return in two places.
> Issue found with Coccinelle.
>
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@...il.com>
> ---
>  drivers/phy/qualcomm/phy-qcom-qmp.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
> index 34ff6434da8f..2f0652efebf0 100644
> --- a/drivers/phy/qualcomm/phy-qcom-qmp.c
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
> @@ -2094,6 +2094,7 @@ static int qcom_qmp_phy_probe(struct platform_device *pdev)
>                         dev_err(dev, "failed to create lane%d phy, %d\n",
>                                 id, ret);
>                         pm_runtime_disable(dev);
> +                       of_node_put(child);
>                         return ret;
>                 }
>
> @@ -2106,6 +2107,7 @@ static int qcom_qmp_phy_probe(struct platform_device *pdev)
>                         dev_err(qmp->dev,
>                                 "failed to register pipe clock source\n");
>                         pm_runtime_disable(dev);
> +                       of_node_put(child);

Nice find. Thanks for the patch.

Reviewed-by: Vivek Gautam <vivek.gautam@...eaurora.org>

Best regards
Vivek

[snip]
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation