linux-kernel - Re: [PATCH] phy: qualcomm: phy-qcom-qmp: Add of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <239020d9-ff8a-237d-b52c-bf2423f9609b@web.de>
Date:   Mon, 5 Aug 2019 14:11:45 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Nishka Dasgupta <nishkadg.linux@...il.com>,
        Andy Gross <agross@...nel.org>,
        Kishon Vijay Abraham I <kishon@...com>,
        Vivek Gautam <vivek.gautam@...eaurora.org>,
        linux-arm-msm@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] phy: qualcomm: phy-qcom-qmp: Add of_node_put() before
 return

> +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
> @@ -2094,6 +2094,7 @@ static int qcom_qmp_phy_probe(struct platform_device *pdev)
>  			dev_err(dev, "failed to create lane%d phy, %d\n",
>  				id, ret);
>  			pm_runtime_disable(dev);
> +			of_node_put(child);
>  			return ret;
>  		}

I suggest to move a bit of common exception handling code to the end of
this function implementation.
Would you like to add a jump target?

Regards,
Markus