linux-kernel - Re: [PATCH] mips: fix vdso32 build, again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 6 Aug 2019 23:02:14 +0000
From:   Paul Burton <paul.burton@...s.com>
To:     Arnd Bergmann <arnd@...db.de>
CC:     Andrew Morton <akpm@...ux-foundation.org>,
        Arnd Bergmann <arnd@...db.de>,
        Guenter Roeck <linux@...ck-us.net>,
        Andrey Konovalov <andreyknvl@...gle.com>,
        Andrey Ryabinin <aryabinin@...tuozzo.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Will Deacon <will.deacon@....com>,
        Christoph Lameter <cl@...ux.com>,
        Mark Rutland <mark.rutland@....com>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Paul Burton <pburton@...ecomp.com>,
        Vincenzo Frascino <vincenzo.frascino@....com>,
        James Hogan <jhogan@...nel.org>,
        "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>
Subject: Re: [PATCH] mips: fix vdso32 build, again

Hello,

Arnd Bergmann wrote:
> The generic vdso support adds the same #if hack in two places,
> asm/vdso/vdso.h and config-n32-o32-env.c, but only the second
> is actually used. The result lacks the BUILD_VDSO32_64 macro,
> and that triggers a build error:
> 
> ./include/linux/page-flags-layout.h:95:2: error: #error "Not enough bits in page flags"
> 
> Move the macro into the other place, and remove the duplicated
> bits.

Applied to mips-next.

> commit 6393e6064486
> https://git.kernel.org/mips/c/6393e6064486
> 
> Reported-by: Guenter Roeck <linux@...ck-us.net>
> Fixes: ee38d94a0ad8 ("page flags: prioritize kasan bits over last-cpuid")
> Fixes: 24640f233b46 ("mips: Add support for generic vDSO")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: Paul Burton <paul.burton@...s.com>

Thanks,
    Paul

[ This message was auto-generated; if you believe anything is incorrect
  then please email paul.burton@...s.com to report it. ]