linux-kernel - Re: [PATCH 3/4] csky/dma: Fixup cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190806064933.GA2508@infradead.org>
Date:   Mon, 5 Aug 2019 23:49:33 -0700
From:   Christoph Hellwig <hch@...radead.org>
To:     guoren@...nel.org
Cc:     arnd@...db.de, linux-kernel@...r.kernel.org,
        linux-arch@...r.kernel.org, linux-csky@...r.kernel.org,
        feng_shizhu@...uatech.com, zhang_jian5@...uatech.com,
        zheng_xingjian@...uatech.com, zhu_peng@...uatech.com,
        Guo Ren <ren_guo@...ky.com>
Subject: Re: [PATCH 3/4] csky/dma: Fixup cache_op failed when cross memory
 ZONEs

On Tue, Jul 30, 2019 at 08:15:44PM +0800, guoren@...nel.org wrote:
> diff --git a/arch/csky/mm/dma-mapping.c b/arch/csky/mm/dma-mapping.c
> index 80783bb..3f1ff9d 100644
> --- a/arch/csky/mm/dma-mapping.c
> +++ b/arch/csky/mm/dma-mapping.c
> @@ -18,71 +18,52 @@ static int __init atomic_pool_init(void)
>  {
>  	return dma_atomic_pool_init(GFP_KERNEL, pgprot_noncached(PAGE_KERNEL));
>  }
> -postcore_initcall(atomic_pool_init);

Please keep the postcore_initcall next to the function it calls.

In this particular case I also plan to remove the function for 5.4 by
moving it to the common dma code, so it is more important than just style.