linux-kernel - Re: [PATCH v2 2/2] spi: npcm-fiu: add NPCM FIU controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 8 Aug 2019 14:27:40 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Tomer Maimon <tmaimon77@...il.com>
Cc:     robh+dt@...nel.org, mark.rutland@....com, vigneshr@...com,
        bbrezillon@...nel.org, avifishman70@...il.com,
        tali.perry1@...il.com, venture@...gle.com, yuenn@...gle.com,
        benjaminfair@...gle.com, linux-spi@...r.kernel.org,
        devicetree@...r.kernel.org, openbmc@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] spi: npcm-fiu: add NPCM FIU controller driver

On Thu, Aug 08, 2019 at 04:14:48PM +0300, Tomer Maimon wrote:

> +	ctrl->mode_bits = SPI_RX_DUAL | SPI_RX_QUAD
> +		| SPI_TX_DUAL | SPI_TX_QUAD;
> +	ctrl->setup = npcm_fiu_setup;

I'm not seeing where we implement dual or quad modes in the driver?
There's some 

> +	dev_info(dev, "NPCM %s probe succeed\n", fiu->info->name);

Just remove this, it makes the log more verbose but doesn't really add
any information.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)