[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 8 Aug 2019 17:32:32 +0200
From: Boris Brezillon <boris.brezillon@...labora.com>
To: Tomer Maimon <tmaimon77@...il.com>
Cc: broonie@...nel.org, robh+dt@...nel.org, mark.rutland@....com,
vigneshr@...com, bbrezillon@...nel.org, avifishman70@...il.com,
tali.perry1@...il.com, venture@...gle.com, yuenn@...gle.com,
benjaminfair@...gle.com, linux-spi@...r.kernel.org,
devicetree@...r.kernel.org, openbmc@...ts.ozlabs.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] spi: npcm-fiu: add NPCM FIU controller driver
On Thu, 8 Aug 2019 16:14:48 +0300
Tomer Maimon <tmaimon77@...il.com> wrote:
> +
> +static const struct spi_controller_mem_ops npcm_fiu_mem_ops = {
> + .exec_op = npcm_fiu_exec_op,
No npcm_supports_op()? That's suspicious, especially after looking at
the npcm_fiu_exec_op() (and the functions called from there) where the
requested ->buswidth seems to be completely ignored...
> + .dirmap_create = npcm_fiu_dirmap_create,
> + .dirmap_read = npcm_fiu_direct_read,
> + .dirmap_write = npcm_fiu_direct_write,
> +};
> +
Powered by blists - more mailing lists