linux-kernel - Re: [PATCH 1/2] cxgb4: smt: Add lock for atomic_dec_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190808.181233.1012759145511078443.davem@davemloft.net>
Date:   Thu, 08 Aug 2019 18:12:33 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hslester96@...il.com
Cc:     vishal@...lsio.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] cxgb4: smt: Add lock for atomic_dec_and_test

From: Chuhong Yuan <hslester96@...il.com>
Date: Tue,  6 Aug 2019 10:58:46 +0800

> The atomic_dec_and_test() is not safe because it is
> outside of locks.
> Move the locks of t4_smte_free() to its caller,
> cxgb4_smt_release() to protect the atomic decrement.
> 
> Fixes: 3bdb376e6944 ("cxgb4: introduce SMT ops to prepare for SMAC rewrite support")
> Signed-off-by: Chuhong Yuan <hslester96@...il.com>

Applied.