linux-kernel - Re: [PATCH 1/4] regulator: dt-bindings: Sort the compatibles and nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 9 Aug 2019 10:01:34 -0700
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Vinod Koul <vkoul@...nel.org>
Cc:     Mark Brown <broonie@...nel.org>, linux-arm-msm@...r.kernel.org,
        Andy Gross <agross@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 1/4] regulator: dt-bindings: Sort the compatibles and
 nodes

On Fri 09 Aug 00:36 PDT 2019, Vinod Koul wrote:

> It helps to keep sorted order for compatibles and nodes, so sort them
> 
> Suggested-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> Signed-off-by: Vinod Koul <vkoul@...nel.org>
> ---
>  .../regulator/qcom,rpmh-regulator.txt         | 19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.txt b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.txt
> index 1a9cab50503a..bab9f71140b8 100644
> --- a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.txt
> +++ b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.txt
> @@ -22,12 +22,12 @@ RPMh resource.
>  
>  The names used for regulator nodes must match those supported by a given PMIC.
>  Supported regulator node names:
> -	PM8998:		smps1 - smps13, ldo1 - ldo28, lvs1 - lvs2
> -	PMI8998:	bob
>  	PM8005:		smps1 - smps4
> +	PM8009:		smps1 - smps2, ldo1 - ldo7
>  	PM8150:		smps1 - smps10, ldo1 - ldo18
>  	PM8150L:	smps1 - smps8, ldo1 - ldo11, bob, flash, rgb
> -	PM8009:		smps1 - smps2, ld01 - ldo7
> +	PM8998:		smps1 - smps13, ldo1 - ldo28, lvs1 - lvs2
> +	PMI8998:	bob
>  
>  ========================
>  First Level Nodes - PMIC
> @@ -36,12 +36,13 @@ First Level Nodes - PMIC
>  - compatible
>  	Usage:      required
>  	Value type: <string>
> -	Definition: Must be one of: "qcom,pm8998-rpmh-regulators",
> -		    "qcom,pmi8998-rpmh-regulators" or
> -		    "qcom,pm8005-rpmh-regulators" or
> -		    "qcom,pm8150-rpmh-regulators" or
> -		    "qcom,pm8150l-rpmh-regulators" or
> -		    "qcom,pm8009-rpmh-regulators".
> +	Definition: Must be one of below:
> +		    "qcom,pm8005-rpmh-regulators"
> +		    "qcom,pm8009-rpmh-regulators"
> +		    "qcom,pm8150-rpmh-regulators"
> +		    "qcom,pm8150l-rpmh-regulators"
> +		    "qcom,pm8998-rpmh-regulators"
> +		    "qcom,pmi8998-rpmh-regulators"

Thanks for dropping the "or" as well.

Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

>  
>  - qcom,pmic-id
>  	Usage:      required
> -- 
> 2.20.1
>