linux-kernel - Re: [PATCH] sh: kernel: disassemble: Mark expected switch fall-throughs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 10 Aug 2019 00:14:02 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Joe Perches <joe@...ches.com>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>
Cc:     linux-sh@...r.kernel.org, linux-kernel@...r.kernel.org,
        Guenter Roeck <linux@...ck-us.net>
Subject: Re: [PATCH] sh: kernel: disassemble: Mark expected switch
 fall-throughs



On 8/10/19 12:08 AM, Joe Perches wrote:
> On Sat, 2019-08-10 at 00:01 -0500, Gustavo A. R. Silva wrote:
>> Mark switch cases where we are expecting to fall through.
>>
>> Fix the following warnings (Building: defconfig sh):
> []
>> diff --git a/arch/sh/kernel/disassemble.c b/arch/sh/kernel/disassemble.c
> []
>> @@ -477,6 +477,7 @@ static void print_sh_insn(u32 memaddr, u16 insn)
>>  			case FD_REG_N:
>>  				if (0)
>>  					goto d_reg_n;
> 
> Might as well remove this if (0) goto,
> remove the added comment
> 

You're right. I'll respin and stop working this Friday midnight.

>> +				/* else, fall through */
>>  			case F_REG_N:
>>  				printk("fr%d", rn);
>>  				break;
>> @@ -488,6 +489,7 @@ static void print_sh_insn(u32 memaddr, u16 insn)
>>  					printk("xd%d", rn & ~1);
>>  					break;
>>  				}
>> +				/* else, fall through */
>>  			d_reg_n:
> 
> and remove this only use of d_reg_n
> 

Sure.

Thanks
--
Gustavo

>>  			case D_REG_N:
>>  				printk("dr%d", rn);
>> @@ -497,6 +499,7 @@ static void print_sh_insn(u32 memaddr, u16 insn)
>>  					printk("xd%d", rm & ~1);
>>  					break;
>>  				}
>> +				/* else, fall through */
>>  			case D_REG_M:
>>  				printk("dr%d", rm);
>>  				break;
>