linux-kernel - Re: [PATCH] ARM: dts: imx7d: sbc-iot-imx7: add recovery for i2c3/4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5b59f3c2b78eaf717885fa005158a0e8a6c51591.camel@toradex.com>
Date:   Mon, 12 Aug 2019 08:50:17 +0000
From:   Philippe Schenker <philippe.schenker@...adex.com>
To:     "git@...red.net" <git@...red.net>
CC:     Max Krummenacher <max.krummenacher@...adex.com>,
        Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "linux-imx@....com" <linux-imx@....com>,
        Oleksandr Suvorov <oleksandr.suvorov@...adex.com>,
        "festevam@...il.com" <festevam@...il.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] ARM: dts: imx7d: sbc-iot-imx7: add recovery for i2c3/4

On Sat, 2019-08-10 at 22:58 +0100, André Draszik wrote:
> On Wed, 07 Aug 2019 08:26:15 +0000, Philippe Schenker wrote:
> > From: Oleksandr Suvorov <oleksandr.suvorov@...adex.com>
> > 
> > - add recovery mode for applicable i2c buses for
> >   Colibri iMX7 module.
> > 
> > Signed-off-by: Oleksandr Suvorov <oleksandr.suvorov@...adex.com>
> > Signed-off-by: Philippe Schenker <philippe.schenker@...adex.com>
> > ---
> > 
> > Changes in v3: None
> > Changes in v2: None
> > 
> >  arch/arm/boot/dts/imx7-colibri.dtsi | 25 +++++++++++++++++++++++--
> >  1 file changed, 23 insertions(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/imx7-colibri.dtsi
> > b/arch/arm/boot/dts/imx7-colibri.dtsi
> > index a8d992f3e897..2480623c92ff 100644
> > --- a/arch/arm/boot/dts/imx7-colibri.dtsi
> > +++ b/arch/arm/boot/dts/imx7-colibri.dtsi
> > @@ -140,8 +140,12 @@
> > 
> >  &i2c1 {
> >  	clock-frequency = <100000>;
> > -	pinctrl-names = "default";
> > +	pinctrl-names = "default", "gpio";
> >  	pinctrl-0 = <&pinctrl_i2c1 &pinctrl_i2c1_int>;
> > +	pinctrl-1 = <&pinctrl_i2c1_recovery &pinctrl_i2c1_int>;
> > +	scl-gpios = <&gpio1 4 GPIO_ACTIVE_HIGH>;
> 
> scl-gpios should be (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN) since
> commit d2d0ad2aec4a ("i2c: imx: use open drain for recovery GPIO")
> 
> Otherwise you'll get a boot-time warning:
>    enforced open drain please flag it properly in DT/ACPI DSDT/board
> file

Thanks for pointing this out, I added this for v4.

Philippe
> 
> > +	sda-gpios = <&gpio1 5 GPIO_ACTIVE_HIGH>;
> > +
> >  	status = "okay";
> > 
> >  	codec: sgtl5000@a {
> > @@ -242,8 +246,11 @@
> > 
> >  &i2c4 {
> >  	clock-frequency = <100000>;
> > -	pinctrl-names = "default";
> > +	pinctrl-names = "default", "gpio";
> >  	pinctrl-0 = <&pinctrl_i2c4>;
> > +	pinctrl-1 = <&pinctrl_i2c4_recovery>;
> > +	scl-gpios = <&gpio7 8 GPIO_ACTIVE_HIGH>;
> 
> and here, too.
> 
> Cheers,
> André