linux-kernel - Re: [PATCH v6 27/57] mfd: Remove dev_err() usage after platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190812093928.GB26727@dell>
Date:   Mon, 12 Aug 2019 10:39:28 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v6 27/57] mfd: Remove dev_err() usage after
 platform_get_irq()

On Tue, 30 Jul 2019, Stephen Boyd wrote:

> We don't need dev_err() messages when platform_get_irq() fails now that
> platform_get_irq() prints an error message itself when something goes
> wrong. Let's remove these prints with a simple semantic patch.
> 
> // <smpl>
> @@
> expression ret;
> struct platform_device *E;
> @@
> 
> ret =
> (
> platform_get_irq(E, ...)
> |
> platform_get_irq_byname(E, ...)
> );
> 
> if ( \( ret < 0 \| ret <= 0 \) )
> {
> (
> -if (ret != -EPROBE_DEFER)
> -{ ...
> -dev_err(...);
> -... }
> |
> ...
> -dev_err(...);
> )
> ...
> }
> // </smpl>
> 
> While we're here, remove braces on if statements that only have one
> statement (manually).
> 
> Cc: Lee Jones <lee.jones@...aro.org>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
> ---
> 
> Please apply directly to subsystem trees
> 
>  drivers/mfd/ab8500-debugfs.c       |  8 ++------
>  drivers/mfd/db8500-prcmu.c         |  4 +---
>  drivers/mfd/fsl-imx25-tsadc.c      |  4 +---
>  drivers/mfd/intel_soc_pmic_bxtwc.c |  4 +---
>  drivers/mfd/jz4740-adc.c           | 11 +++--------
>  drivers/mfd/qcom_rpm.c             | 12 +++---------
>  drivers/mfd/sm501.c                |  4 +---
>  7 files changed, 12 insertions(+), 35 deletions(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog