linux-kernel - Re: [PATCH v6 39/57] rtc: Remove dev_err() usage after platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190813085331.GX3600@piout.net>
Date:   Tue, 13 Aug 2019 10:53:31 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     linux-kernel@...r.kernel.org,
        Alessandro Zummo <a.zummo@...ertech.it>,
        linux-rtc@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH v6 39/57] rtc: Remove dev_err() usage after
 platform_get_irq()

On 30/07/2019 11:15:39-0700, Stephen Boyd wrote:
> We don't need dev_err() messages when platform_get_irq() fails now that
> platform_get_irq() prints an error message itself when something goes
> wrong. Let's remove these prints with a simple semantic patch.
> 
> // <smpl>
> @@
> expression ret;
> struct platform_device *E;
> @@
> 
> ret =
> (
> platform_get_irq(E, ...)
> |
> platform_get_irq_byname(E, ...)
> );
> 
> if ( \( ret < 0 \| ret <= 0 \) )
> {
> (
> -if (ret != -EPROBE_DEFER)
> -{ ...
> -dev_err(...);
> -... }
> |
> ...
> -dev_err(...);
> )
> ...
> }
> // </smpl>
> 
> While we're here, remove braces on if statements that only have one
> statement (manually).
> 
> Cc: Alessandro Zummo <a.zummo@...ertech.it>
> Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>
> Cc: linux-rtc@...r.kernel.org
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
> ---
> 
> Please apply directly to subsystem trees
> 
>  drivers/rtc/rtc-88pm80x.c    | 1 -
>  drivers/rtc/rtc-88pm860x.c   | 4 +---
>  drivers/rtc/rtc-ac100.c      | 4 +---
>  drivers/rtc/rtc-armada38x.c  | 5 +----
>  drivers/rtc/rtc-asm9260.c    | 4 +---
>  drivers/rtc/rtc-at91rm9200.c | 4 +---
>  drivers/rtc/rtc-at91sam9.c   | 4 +---
>  drivers/rtc/rtc-bd70528.c    | 5 +----
>  drivers/rtc/rtc-davinci.c    | 4 +---
>  drivers/rtc/rtc-jz4740.c     | 4 +---
>  drivers/rtc/rtc-max77686.c   | 5 +----
>  drivers/rtc/rtc-mt7622.c     | 1 -
>  drivers/rtc/rtc-pic32.c      | 4 +---
>  drivers/rtc/rtc-pm8xxx.c     | 4 +---
>  drivers/rtc/rtc-puv3.c       | 8 ++------
>  drivers/rtc/rtc-pxa.c        | 8 ++------
>  drivers/rtc/rtc-rk808.c      | 6 +-----
>  drivers/rtc/rtc-s3c.c        | 8 ++------
>  drivers/rtc/rtc-sc27xx.c     | 4 +---
>  drivers/rtc/rtc-spear.c      | 4 +---
>  drivers/rtc/rtc-stm32.c      | 1 -
>  drivers/rtc/rtc-sun6i.c      | 4 +---
>  drivers/rtc/rtc-sunxi.c      | 4 +---
>  drivers/rtc/rtc-tegra.c      | 4 +---
>  drivers/rtc/rtc-vt8500.c     | 4 +---
>  drivers/rtc/rtc-xgene.c      | 4 +---
>  drivers/rtc/rtc-zynqmp.c     | 8 ++------
>  27 files changed, 28 insertions(+), 92 deletions(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com