linux-kernel - Re: [PATCH v4] ata/pata_buddha: Probe via modalias instead of initcall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27f3bb2f-e4b8-cfc9-26da-d0984f1bf37b@enpas.org>
Date:   Mon, 12 Aug 2019 12:55:05 +0200
From:   Max Staudt <max@...as.org>
To:     Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Cc:     axboe@...nel.dk, linux-ide@...r.kernel.org,
        linux-m68k@...r.kernel.org, linux-kernel@...r.kernel.org,
        glaubitz@...sik.fu-berlin.de, schmitzmic@...il.com,
        geert@...ux-m68k.org
Subject: Re: [PATCH v4] ata/pata_buddha: Probe via modalias instead of
 initcall

Hi Bartlomiej,

Thanks for your feedback!


On 08/12/2019 12:42 PM, Bartlomiej Zolnierkiewicz wrote:
> 
> ide/buddha driver cannot be unloaded currently (it lacks module_exit()).
> 
> [... snip ...]
> 
> It should work exactly like the old code in case of X-Surf,
> what do we need to release?


So what shall I do? Once an X-Surf has been detected, we refuse to unload, and therefore we never have to release X-Surf resources? That would simplify things a lot.

What's a good way to do that, given that we now have module_exit() defined and an exit function is void?


Thanks,
Max