[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1BB38E27-5FAD-4402-86C1-6AA47E6BA08A@holtmann.org>
Date: Mon, 12 Aug 2019 18:35:20 +0200
From: Marcel Holtmann <marcel@...tmann.org>
To: Alex Lu <alex_lu@...lsil.com.cn>
Cc: Johan Hedberg <johan.hedberg@...il.com>,
linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org,
Max Chou <max.chou@...ltek.com>
Subject: Re: [PATCH v2] Bluetooth: btrtl: Save firmware and config
Hi Alex,
> usb reset resume will cause downloading firmware again and
> requesting firmware may be failed while host is resuming
>
> Signed-off-by: Alex Lu <alex_lu@...lsil.com.cn>
> ---
> drivers/bluetooth/btrtl.c | 101 ++++++++++++++++++++++++++++++++++++--
> 1 file changed, 97 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
> index 208feef63de4..416a5cb676e3 100644
> --- a/drivers/bluetooth/btrtl.c
> +++ b/drivers/bluetooth/btrtl.c
> @@ -56,6 +56,8 @@ struct btrtl_device_info {
> int cfg_len;
> };
>
> +static struct btrtl_device_info dev_info;
> +
No. We are are not using magic global variables. What happens if you attach more than one device? Also I assumed that request_firmware has a caching capability of sorts so that drivers don’t have to re-implement caching of the firmware.
Regards
Marcel
Powered by blists - more mailing lists