linux-kernel - 答复: [PATCH v2] Bluetooth: btrtl: Save firmware and config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0551C926975A174EA8972327741C7889EE81187B@RS-MBS01.realsil.com.cn>
Date:   Wed, 14 Aug 2019 07:31:44 +0000
From:   陆朱伟 <alex_lu@...lsil.com.cn>
To:     Marcel Holtmann <marcel@...tmann.org>
CC:     Johan Hedberg <johan.hedberg@...il.com>,
        "linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Max Chou <max.chou@...ltek.com>
Subject: 答复: [PATCH v2] Bluetooth: btrtl: Save firmware and config

Hi Marcel,
It only saves the latest fw and config for only one device.
I will dig the caching capability of request_firmware first.

Thanks,
BRs,

> Subject: Re: [PATCH v2] Bluetooth: btrtl: Save firmware and config
> 
> Hi Alex,
> 
> > usb reset resume will cause downloading firmware again and
> > requesting firmware may be failed while host is resuming
> >
> > Signed-off-by: Alex Lu <alex_lu@...lsil.com.cn>
> > ---
> > drivers/bluetooth/btrtl.c | 101
> ++++++++++++++++++++++++++++++++++++--
> > 1 file changed, 97 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
> > index 208feef63de4..416a5cb676e3 100644
> > --- a/drivers/bluetooth/btrtl.c
> > +++ b/drivers/bluetooth/btrtl.c
> > @@ -56,6 +56,8 @@ struct btrtl_device_info {
> > 	int cfg_len;
> > };
> >
> > +static struct btrtl_device_info dev_info;
> > +
> 
> No. We are are not using magic global variables. What happens if you attach
> more than one device? Also I assumed that request_firmware has a caching
> capability of sorts so that drivers don’t have to re-implement caching of the
> firmware.
> 
> Regards
> 
> Marcel
> 
> 
> ------Please consider the environment before printing this e-mail.