linux-kernel - Re: [EXT] Re: [PATCHv5 1/2] PCI: layerscape: Add the bar_fixed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Aug 2019 10:51:51 +0100
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Xiaowei Bao <xiaowei.bao@....com>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "M.h. Lian" <minghuan.lian@....com>,
        Mingkai Hu <mingkai.hu@....com>, Roy Zang <roy.zang@....com>,
        "l.stach@...gutronix.de" <l.stach@...gutronix.de>,
        "tpiepho@...inj.com" <tpiepho@...inj.com>,
        Leonard Crestez <leonard.crestez@....com>,
        "andrew.smirnov@...il.com" <andrew.smirnov@...il.com>,
        "yue.wang@...ogic.com" <yue.wang@...ogic.com>,
        "hayashi.kunihiko@...ionext.com" <hayashi.kunihiko@...ionext.com>,
        "dwmw@...zon.co.uk" <dwmw@...zon.co.uk>,
        "jonnyc@...zon.com" <jonnyc@...zon.com>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [EXT] Re: [PATCHv5 1/2] PCI: layerscape: Add the bar_fixed_64bit
 property in EP driver.

You should fix your email client set-up to avoid sticking an [EXT]
tag to your emails $SUBJECT.

On Tue, Aug 13, 2019 at 07:39:48AM +0000, Xiaowei Bao wrote:
> 
> 
> > -----Original Message-----
> > From: Kishon Vijay Abraham I <kishon@...com>
> > Sent: 2019年8月13日 15:30
> > To: Xiaowei Bao <xiaowei.bao@....com>; lorenzo.pieralisi@....com;
> > bhelgaas@...gle.com; M.h. Lian <minghuan.lian@....com>; Mingkai Hu
> > <mingkai.hu@....com>; Roy Zang <roy.zang@....com>;
> > l.stach@...gutronix.de; tpiepho@...inj.com; Leonard Crestez
> > <leonard.crestez@....com>; andrew.smirnov@...il.com;
> > yue.wang@...ogic.com; hayashi.kunihiko@...ionext.com;
> > dwmw@...zon.co.uk; jonnyc@...zon.com; linux-pci@...r.kernel.org;
> > linux-kernel@...r.kernel.org; linuxppc-dev@...ts.ozlabs.org;
> > linux-arm-kernel@...ts.infradead.org
> > Subject: [EXT] Re: [PATCHv5 1/2] PCI: layerscape: Add the bar_fixed_64bit
> > property in EP driver.
> > 
> > Caution: EXT Email

See above, this "Caution" stuff should disappear.

Also, quoting the email header is useless, please configure your email
client to remove it.

Thanks,
Lorenzo

> > On 13/08/19 11:58 AM, Xiaowei Bao wrote:
> > > The PCIe controller of layerscape just have 4 BARs, BAR0 and BAR1 is
> > > 32bit, BAR2 and BAR4 is 64bit, this is determined by hardware, so set
> > > the bar_fixed_64bit with 0x14.
> > >
> > > Signed-off-by: Xiaowei Bao <xiaowei.bao@....com>
> > 
> > Acked-by: Kishon Vijay Abraham I <kishon@...com>
> > > ---
> > > v2:
> > >  - Replace value 0x14 with a macro.
> > > v3:
> > >  - No change.
> > > v4:
> > >  - send the patch again with '--to'.
> > > v5:
> > >  - fix the commit message.
> > >
> > >  drivers/pci/controller/dwc/pci-layerscape-ep.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/pci/controller/dwc/pci-layerscape-ep.c
> > > b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> > > index be61d96..ca9aa45 100644
> > > --- a/drivers/pci/controller/dwc/pci-layerscape-ep.c
> > > +++ b/drivers/pci/controller/dwc/pci-layerscape-ep.c
> > > @@ -44,6 +44,7 @@ static const struct pci_epc_features
> > ls_pcie_epc_features = {
> > >       .linkup_notifier = false,
> > >       .msi_capable = true,
> > >       .msix_capable = false,
> > > +     .bar_fixed_64bit = (1 << BAR_2) | (1 << BAR_4),
> > >  };
> > >
> > >  static const struct pci_epc_features*
> I check other platforms, it is 'static const struct pci_epc_features', I can get the correct 
> Value use this define way in pci-epf-test.c file.
> > >