linux-kernel - Re: [PATCH 6/9] sparc/perf: correctly check for kthreads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190814.122618.1414289033357500978.davem@davemloft.net>
Date:   Wed, 14 Aug 2019 12:26:18 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     mark.rutland@....com
Cc:     linux-kernel@...r.kernel.org, ak@...ux.intel.com,
        akpm@...ux-foundation.org, bigeasy@...utronix.de, bp@...e.de,
        catalin.marinas@....com, hch@....de, kan.liang@...el.com,
        mingo@...nel.org, peterz@...radead.org, riel@...riel.com,
        will@...nel.org
Subject: Re: [PATCH 6/9] sparc/perf: correctly check for kthreads

From: Mark Rutland <mark.rutland@....com>
Date: Wed, 14 Aug 2019 11:41:28 +0100

> The sparc perf_callchain_user() functions looks at current->mm,
> apparently to determine whether the thread is a kthread without any
> valid user context.
> 
> In general, a non-NULL current->mm doesn't imply that current is a
> kthread, as kthreads can install an mm via use_mm(), and so it's
> preferable to use is_kthread() to determine whether a thread is a
> kthread.
> 
> For consistency, let's use is_kthread() here.
> 
> Signed-off-by: Mark Rutland <mark.rutland@....com>

Acked-by: David S. Miller <davem@...emloft.net>