lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 14 Aug 2019 12:38:51 +0800 From: Chen-Yu Tsai <wens@...e.org> To: Maxime Ripard <mripard@...nel.org> Cc: Guenter Roeck <linux@...ck-us.net>, Wim Van Sebroeck <wim@...ux-watchdog.org>, linux-kernel <linux-kernel@...r.kernel.org>, Mark Rutland <mark.rutland@....com>, Rob Herring <robh+dt@...nel.org>, Frank Rowand <frowand.list@...il.com>, linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, devicetree <devicetree@...r.kernel.org>, Maxime Ripard <maxime.ripard@...tlin.com> Subject: Re: [PATCH 4/5] ARM: dts: sun8i: a83t: Remove the watchdog clock On Tue, Aug 13, 2019 at 8:47 PM Maxime Ripard <mripard@...nel.org> wrote: > > From: Maxime Ripard <maxime.ripard@...tlin.com> > > The watchdog binding doesn't define a clock, and it indeed looks like > there's no explicit clock feeding it. The diagram on page 133 of the manual shows OSC24M / 750 feeding the watchdog. Other manuals, such as the A10 one, mention: Watchdog clock source is OSC24M. if the OSC24M is turned off, the watchdog will not work. So in fact it does use a clock signal. It's just that we've been lazy, since the clock rate is fixed and is always on. ChenYu > Let's remove it from our DT. > > Signed-off-by: Maxime Ripard <maxime.ripard@...tlin.com> > --- > arch/arm/boot/dts/sun8i-a83t.dtsi | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi > index 523be6611c50..15f8c80f69a5 100644 > --- a/arch/arm/boot/dts/sun8i-a83t.dtsi > +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi > @@ -817,7 +817,6 @@ > compatible = "allwinner,sun6i-a31-wdt"; > reg = <0x01c20ca0 0x20>; > interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&osc24M>; > }; > > spdif: spdif@...1000 { > -- > 2.21.0 >
Powered by blists - more mailing lists