[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20190814131335.GF9716@ninjato>
Date: Wed, 14 Aug 2019 15:13:35 +0200
From: Wolfram Sang <wsa@...-dreams.de>
To: "Adamski, Krzysztof (Nokia - PL/Wroclaw)"
<krzysztof.adamski@...ia.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
"Sverdlin, Alexander (Nokia - DE/Ulm)" <alexander.sverdlin@...ia.com>
Subject: Re: [PATCH v2] i2c: axxia: support slave mode
Hi Krzysztof,
> - Reduced the number of dev_dbg messages.
Yes, that looks good. Just some curly braces left over...
> + if (fifo_status & SLV_FIFO_STRC) {
> + i2c_slave_event(idev->slave,
> + I2C_SLAVE_WRITE_REQUESTED, &val);
> + }
...
> + if (fifo_status & SLV_FIFO_RSC) {
> + readl(idev->base + SLV_DATA); /* dummy read */
> + }
..
> + if (status & SLV_STATUS_SRC1) {
> + i2c_slave_event(idev->slave, I2C_SLAVE_STOP, &val);
> + }
If you add '--strict' to checkpatch, it warns about two of them.
Kind regards,
Wolfram
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists