linux-kernel - Re: [PATCH 2/9] sched: treewide: use is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8647b1da-e654-714a-ce6e-7b92110a066f@arm.com>
Date:   Wed, 14 Aug 2019 14:37:21 +0100
From:   Valentin Schneider <valentin.schneider@....com>
To:     Mark Rutland <mark.rutland@....com>, linux-kernel@...r.kernel.org
Cc:     ak@...ux.intel.com, akpm@...ux-foundation.org,
        bigeasy@...utronix.de, bp@...e.de, catalin.marinas@....com,
        davem@...emloft.net, hch@....de, kan.liang@...el.com,
        mingo@...nel.org, peterz@...radead.org, riel@...riel.com,
        will@...nel.org
Subject: Re: [PATCH 2/9] sched: treewide: use is_kthread()

On 14/08/2019 11:41, Mark Rutland wrote:
> Now that we have is_kthread(), let's convert existing open-coded checks
> of the form:
> 
>   task->flags & PF_KTHREAD
> 
> ... over to the new helper, which makes things a little easier to read,
> and sets a consistent example for new code to follow.
> 

[...]

>  kernel/sched/core.c              | 8 ++++----
>  kernel/sched/idle.c              | 2 +-
>  kernel/sched/wait.c              | 2 +-

Looks all sane there for me.

Reviewed-by: Valentin Schneider <valentin.schneider@....com>