linux-kernel - Re: [PATCH v2 1/4] i2c/busses: Add i2c-icy for I2C on m68k/Amiga

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190815120430.GB1916@kunai>
Date:   Thu, 15 Aug 2019 14:04:30 +0200
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Max <max@...as.org>
Cc:     linux-i2c@...r.kernel.org, linux-hwmon@...r.kernel.org,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Jean Delvare <jdelvare@...e.com>,
        Guenter Roeck <linux@...ck-us.net>, linux-m68k@...r.kernel.org,
        linux-kernel@...r.kernel.org, glaubitz@...sik.fu-berlin.de
Subject: Re: [PATCH v2 1/4] i2c/busses: Add i2c-icy for I2C on m68k/Amiga


> My suggestion is to not touch i2c-elektor at all for now, and remove
> the 'clock' parameter from the first iteration of i2c-icy. It can be
> added back in case someone complains, which I deem unlikely.

Full ack.

>   When the PCF8584 is addressed as slave, this register
>   must be loaded with the 7-bit I 2 C-bus address to which the
>   PCF8584 is to respond. During initialization, the own
>   address register S0' must be written to, regardless
>   whether it is later used.

I see. It must be written a non-zero value to leave the monitor mode.
But this really needs no callback, we can hardcode any non-zero value.
If slave support is (ever) to be implemented, the own address will come
from the I2C core.

> Okay, so we don't care. Cool, then it's safe to kick the 'clock'
> parameter from i2c-icy. All 2019 boards (which should be the vast
> majority in existence) came with a 12 MHz oscillator AFAIK, so the
> default should be good.

Most drivers don't allow users to change the bus speed, so I think it is
safe to remove.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)