linux-kernel - Re: [PATCH v2 20/22] watchdog: ziirave_wdt: Fix DOWNLOAD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190815182442.GP14388@roeck-us.net>
Date:   Thu, 15 Aug 2019 11:24:42 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Andrey Smirnov <andrew.smirnov@...il.com>
Cc:     linux-watchdog@...r.kernel.org, Chris Healy <cphealy@...il.com>,
        Rick Ramstetter <rick@...eaterllc.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 20/22] watchdog: ziirave_wdt: Fix DOWNLOAD_START
 payload

On Mon, Aug 12, 2019 at 01:09:04PM -0700, Andrey Smirnov wrote:
> Bootloader firmware expects the following traffic for DOWNLOAD_END:
> 
> S Addr Wr [A] 0x10 [A] P
> 
> using ziirave_firm_write_byte() will result in
> 
> S Addr Wr [A] 0x10 [A] 0x01 [A] 0x01 [A] P
> 
> which happens to work because firmware will ignore any extra bytes
> sent. Fix this by converting the code to use i2c_smbus_write_byte()
> instead.
> 
> Signed-off-by: Andrey Smirnov <andrew.smirnov@...il.com>
> Cc: Chris Healy <cphealy@...il.com>
> Cc: Guenter Roeck <linux@...ck-us.net>
> Cc: Rick Ramstetter <rick@...eaterllc.com>
> Cc: linux-watchdog@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org

Reviewed-by: Guenter Roeck <linux@...ck-us.net>