linux-kernel - Re: [PATCH v4 14/21] ARM: dts: imx6ull-colibri: Add sleep mode to fec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGgjyvHQt_Gp+Pm5VFabGHY5xGN4fU1Xv3inGRf9vmsRm3fQBQ@mail.gmail.com>
Date:   Fri, 16 Aug 2019 07:09:20 +0000
From:   Oleksandr Suvorov <oleksandr.suvorov@...adex.com>
To:     Philippe Schenker <philippe.schenker@...adex.com>
CC:     Marcel Ziswiler <marcel.ziswiler@...adex.com>,
        Max Krummenacher <max.krummenacher@...adex.com>,
        "stefan@...er.ch" <stefan@...er.ch>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Michal Vokáč <michal.vokac@...ft.com>,
        Fabio Estevam <festevam@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        NXP Linux Team <linux-imx@....com>,
        Sascha Hauer <s.hauer@...gutronix.de>
Subject: Re: [PATCH v4 14/21] ARM: dts: imx6ull-colibri: Add sleep mode to fec

On Mon, Aug 12, 2019 at 5:22 PM Philippe Schenker
<philippe.schenker@...adex.com> wrote:
>
> Do not change the clock as the power for this phy is switched
> with that clock.
>
> Signed-off-by: Philippe Schenker <philippe.schenker@...adex.com>
> Acked-by: Marcel Ziswiler <marcel.ziswiler@...adex.com>

Reviewed-by: Oleksandr Suvorov <oleksandr.suvorov@...adex.com>

>
> ---
>
> Changes in v4:
> - Add Marcel Ziswiler's Ack
>
> Changes in v3: None
> Changes in v2: None
>
>  arch/arm/boot/dts/imx6ull-colibri.dtsi | 18 +++++++++++++++++-
>  1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx6ull-colibri.dtsi b/arch/arm/boot/dts/imx6ull-colibri.dtsi
> index d56728f03c35..1019ce69a242 100644
> --- a/arch/arm/boot/dts/imx6ull-colibri.dtsi
> +++ b/arch/arm/boot/dts/imx6ull-colibri.dtsi
> @@ -62,8 +62,9 @@
>  };
>
>  &fec2 {
> -       pinctrl-names = "default";
> +       pinctrl-names = "default", "sleep";
>         pinctrl-0 = <&pinctrl_enet2>;
> +       pinctrl-1 = <&pinctrl_enet2_sleep>;
>         phy-mode = "rmii";
>         phy-handle = <&ethphy1>;
>         status = "okay";
> @@ -220,6 +221,21 @@
>                 >;
>         };
>
> +       pinctrl_enet2_sleep: enet2sleepgrp {
> +               fsl,pins = <
> +                       MX6UL_PAD_GPIO1_IO06__GPIO1_IO06        0x0
> +                       MX6UL_PAD_GPIO1_IO07__GPIO1_IO07        0x0
> +                       MX6UL_PAD_ENET2_RX_DATA0__GPIO2_IO08    0x0
> +                       MX6UL_PAD_ENET2_RX_DATA1__GPIO2_IO09    0x0
> +                       MX6UL_PAD_ENET2_RX_EN__GPIO2_IO10       0x0
> +                       MX6UL_PAD_ENET2_RX_ER__GPIO2_IO15       0x0
> +                       MX6UL_PAD_ENET2_TX_CLK__ENET2_REF_CLK2  0x4001b031
> +                       MX6UL_PAD_ENET2_TX_DATA0__GPIO2_IO11    0x0
> +                       MX6UL_PAD_ENET2_TX_DATA1__GPIO2_IO12    0x0
> +                       MX6UL_PAD_ENET2_TX_EN__GPIO2_IO13       0x0
> +               >;
> +       };
> +
>         pinctrl_ecspi1_cs: ecspi1-cs-grp {
>                 fsl,pins = <
>                         MX6UL_PAD_LCD_DATA21__GPIO3_IO26        0x000a0
> --
> 2.22.0
>


-- 
Best regards
Oleksandr Suvorov

Toradex AG
Altsagenstrasse 5 | 6048 Horw/Luzern | Switzerland | T: +41 41 500
4800 (main line)