linux-kernel - Re: [PATCH v4] media: si2168: Refactor command setup code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <499bea86-f483-f776-4512-510c5df9d78f@free.fr>
Date:   Mon, 19 Aug 2019 13:54:53 +0200
From:   Marc Gonzalez <marc.w.gonzalez@...e.fr>
To:     Antti Palosaari <crope@....fi>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Sean Young <sean@...s.org>, Brad Love <brad@...tdimension.cc>
Cc:     linux-media <linux-media@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Jonathan Neuschäfer <j.neuschaefer@....net>
Subject: Re: [PATCH v4] media: si2168: Refactor command setup code

On 15/07/2019 11:50, Marc Gonzalez wrote:

> Use cmd_init() to fill a struct si2168_cmd command.
> 
> Signed-off-by: Marc Gonzalez <marc.w.gonzalez@...e.fr>
> ---
> Changes from v1:
> - Use a real function to populate struct si2168_cmd *cmd, and a trivial
> macro wrapping it (macro because sizeof).
> Changes from v2:
> - Fix header mess
> - Add Jonathan's tag
> Changes from v3:
> - Drop Jonathan's tag after rewrite
> - Completely drop macro, and explicitly provide 'wlen' argument
> ---
>  drivers/media/dvb-frontends/si2168.c | 152 ++++++++-------------------
>  1 file changed, 44 insertions(+), 108 deletions(-)

Brad, Sean, Antti,

I believe this patch is good to go. Is anything still wrong with it?

Regards.