linux-kernel - Re: [PATCH v4] media: si2168: Refactor command setup code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190822091002.7v7slkrilwfz3d3c@gofer.mess.org>
Date:   Thu, 22 Aug 2019 10:10:02 +0100
From:   Sean Young <sean@...s.org>
To:     Marc Gonzalez <marc.w.gonzalez@...e.fr>
Cc:     Antti Palosaari <crope@....fi>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Brad Love <brad@...tdimension.cc>,
        linux-media <linux-media@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Jonathan Neuschäfer <j.neuschaefer@....net>
Subject: Re: [PATCH v4] media: si2168: Refactor command setup code

On Mon, Aug 19, 2019 at 01:54:53PM +0200, Marc Gonzalez wrote:
> On 15/07/2019 11:50, Marc Gonzalez wrote:
> 
> > Use cmd_init() to fill a struct si2168_cmd command.
> > 
> > Signed-off-by: Marc Gonzalez <marc.w.gonzalez@...e.fr>
> > ---
> > Changes from v1:
> > - Use a real function to populate struct si2168_cmd *cmd, and a trivial
> > macro wrapping it (macro because sizeof).
> > Changes from v2:
> > - Fix header mess
> > - Add Jonathan's tag
> > Changes from v3:
> > - Drop Jonathan's tag after rewrite
> > - Completely drop macro, and explicitly provide 'wlen' argument
> > ---
> >  drivers/media/dvb-frontends/si2168.c | 152 ++++++++-------------------
> >  1 file changed, 44 insertions(+), 108 deletions(-)
> 
> Brad, Sean, Antti,
> 
> I believe this patch is good to go. Is anything still wrong with it?

It's been accepted:

https://git.linuxtv.org/media_tree.git/commit/?id=619f6fc390909fce3247c3e07e6882b868b645da

Thanks,

Sean