linux-kernel - Re: [PATCH] infiniband: hfi1: fix memory leaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <da3f6be9-68e1-0db0-ee9d-55f10fc60bfb@intel.com>
Date:   Mon, 19 Aug 2019 09:11:29 -0400
From:   Dennis Dalessandro <dennis.dalessandro@...el.com>
To:     Wenwen Wang <wenwen@...uga.edu>
Cc:     Mike Marciniszyn <mike.marciniszyn@...el.com>,
        Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        "open list:HFI1 DRIVER" <linux-rdma@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] infiniband: hfi1: fix memory leaks

On 8/18/2019 2:54 PM, Wenwen Wang wrote:
> In fault_opcodes_write(), 'data' is allocated through kcalloc(). However,
> it is not deallocated in the following execution if an error occurs,
> leading to memory leaks. To fix this issue, introduce the 'free_data' label
> to free 'data' before returning the error.
> 
> Signed-off-by: Wenwen Wang <wenwen@...uga.edu>

Acked-by: Dennis Dalessandro <dennis.dalessandro@...el.com>