[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <e3b24621-82cc-cd66-7b27-32afd3c07680@suse.cz>
Date: Mon, 19 Aug 2019 15:11:41 +0200
From: Vlastimil Babka <vbabka@...e.cz>
To: "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Cc: "Kirill A. Shutemov" <kirill@...temov.name>, linux-mm@...ck.org,
Andrew Morton <akpm@...ux-foundation.org>,
linux-kernel@...r.kernel.org, Michal Hocko <mhocko@...nel.org>,
Mel Gorman <mgorman@...hsingularity.net>,
Matthew Wilcox <willy@...radead.org>
Subject: Re: [PATCH 1/3] mm, page_owner: record page owner for each subpage
On 8/19/19 1:57 PM, Kirill A. Shutemov wrote:
> On Mon, Aug 19, 2019 at 11:55:51AM +0000, Kirill A. Shutemov wrote:
>>> @@ -2533,6 +2534,8 @@ static void __split_huge_page(struct page *page, struct list_head *list,
>>>
>>> remap_page(head);
>>>
>>> + split_page_owner(head, HPAGE_PMD_ORDER);
>>> +
>>
>> I think it has to be before remap_page(). This way nobody would be able to
>> mess with the page until it has valid page_owner.
>
> Or rather next to ClearPageCompound().
OK, will wait for more feedback and repost with that patch first, and as
you suggest.
Powered by blists - more mailing lists