linux-kernel - Re: [PATCH] auxdisplay: ht16k33: Make ht16k33_fb_fix and ht16k33_fb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72m5LsZKY-WU+63Rt9EfXW51SN-QGXg17AciounFQdsAPw@mail.gmail.com>
Date:   Mon, 19 Aug 2019 18:48:03 +0200
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Nishka Dasgupta <nishkadg.linux@...il.com>
Cc:     Robin van der Gracht <robin@...tonic.nl>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] auxdisplay: ht16k33: Make ht16k33_fb_fix and
 ht16k33_fb_var constant

On Mon, Aug 19, 2019 at 9:51 AM Nishka Dasgupta
<nishkadg.linux@...il.com> wrote:
>
> The static structures ht16k33_fb_fix and ht16k33_fb_var, of types
> fb_fix_screeninfo and fb_var_screeninfo respectively, are not used
> except to be copied into other variables. Hence make both of them
> constant to prevent unintended modification.
> Issue found with
> Coccinelle.

Thanks Nishka, picking it up.

Cheers,
Miguel