linux-kernel - Re: [PATCH] auxdisplay: ht16k33: Make ht16k33_fb_fix and ht16k33_fb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <894371cda58112ee77cc0c8a5d336d2d@protonic.nl>
Date:   Tue, 20 Aug 2019 08:28:29 +0200
From:   Robin van der Gracht <robin@...tonic.nl>
To:     Nishka Dasgupta <nishkadg.linux@...il.com>
Cc:     miguel.ojeda.sandonis@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] auxdisplay: ht16k33: Make ht16k33_fb_fix and
 ht16k33_fb_var constant

On 2019-08-19 09:51, Nishka Dasgupta wrote:
> The static structures ht16k33_fb_fix and ht16k33_fb_var, of types
> fb_fix_screeninfo and fb_var_screeninfo respectively, are not used
> except to be copied into other variables. Hence make both of them
> constant to prevent unintended modification.
> Issue found with
> Coccinelle.
> 
> Signed-off-by: Nishka Dasgupta <nishkadg.linux@...il.com>
> ---
>  drivers/auxdisplay/ht16k33.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/auxdisplay/ht16k33.c 
> b/drivers/auxdisplay/ht16k33.c
> index 9c0bb771751d..a2fcde582e2a 100644
> --- a/drivers/auxdisplay/ht16k33.c
> +++ b/drivers/auxdisplay/ht16k33.c
> @@ -74,7 +74,7 @@ struct ht16k33_priv {
>  	struct ht16k33_fbdev fbdev;
>  };
> 
> -static struct fb_fix_screeninfo ht16k33_fb_fix = {
> +static const struct fb_fix_screeninfo ht16k33_fb_fix = {
>  	.id		= DRIVER_NAME,
>  	.type		= FB_TYPE_PACKED_PIXELS,
>  	.visual		= FB_VISUAL_MONO10,
> @@ -85,7 +85,7 @@ static struct fb_fix_screeninfo ht16k33_fb_fix = {
>  	.accel		= FB_ACCEL_NONE,
>  };
> 
> -static struct fb_var_screeninfo ht16k33_fb_var = {
> +static const struct fb_var_screeninfo ht16k33_fb_var = {
>  	.xres = HT16K33_MATRIX_LED_MAX_ROWS,
>  	.yres = HT16K33_MATRIX_LED_MAX_COLS,
>  	.xres_virtual = HT16K33_MATRIX_LED_MAX_ROWS,

ACK

Robin