linux-kernel - Re: [PATCH 7/9] drivers: ata: sata_dwc_460ex: use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 20 Aug 2019 15:31:32 +0200
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     "Enrico Weigelt, metux IT consult" <info@...ux.net>
Cc:     linux-kernel@...r.kernel.org, axboe@...nel.dk, hdegoede@...hat.com,
        linus.walleij@...aro.org, linux-ide@...r.kernel.org,
        linux-tegra@...r.kernel.org
Subject: Re: [PATCH 7/9] drivers: ata: sata_dwc_460ex: use
 devm_platform_ioremap_resource()


On 8/20/19 2:35 PM, Enrico Weigelt, metux IT consult wrote:
> Use the new helper that wraps the calls to platform_get_resource()
> and devm_ioremap_resource() together.
> 
> Signed-off-by: Enrico Weigelt, metux IT consult <info@...ux.net>

Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
>  drivers/ata/sata_dwc_460ex.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c
> index 9dcef6a..de248fa 100644
> --- a/drivers/ata/sata_dwc_460ex.c
> +++ b/drivers/ata/sata_dwc_460ex.c
> @@ -237,7 +237,6 @@ static int sata_dwc_dma_init_old(struct platform_device *pdev,
>  				 struct sata_dwc_device *hsdev)
>  {
>  	struct device_node *np = pdev->dev.of_node;
> -	struct resource *res;
>  
>  	hsdev->dma = devm_kzalloc(&pdev->dev, sizeof(*hsdev->dma), GFP_KERNEL);
>  	if (!hsdev->dma)
> @@ -254,8 +253,7 @@ static int sata_dwc_dma_init_old(struct platform_device *pdev,
>  	}
>  
>  	/* Get physical SATA DMA register base address */
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> -	hsdev->dma->regs = devm_ioremap_resource(&pdev->dev, res);
> +	hsdev->dma->regs = devm_platform_ioremap_resource(pdev, 1);
>  	if (IS_ERR(hsdev->dma->regs))
>  		return PTR_ERR(hsdev->dma->regs);