linux-kernel - Re: [PATCH 8/9] drivers: ata: sata_gemini: use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f7a9d877-e437-e22e-f9f8-d8da62273aa5@samsung.com>
Date:   Tue, 20 Aug 2019 15:36:35 +0200
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     "Enrico Weigelt, metux IT consult" <info@...ux.net>
Cc:     linux-kernel@...r.kernel.org, axboe@...nel.dk, hdegoede@...hat.com,
        linus.walleij@...aro.org, linux-ide@...r.kernel.org,
        linux-tegra@...r.kernel.org
Subject: Re: [PATCH 8/9] drivers: ata: sata_gemini: use
 devm_platform_ioremap_resource()


On 8/20/19 2:35 PM, Enrico Weigelt, metux IT consult wrote:
> Use the new helper that wraps the calls to platform_get_resource()
> and devm_ioremap_resource() together.

It would also be worth to mention in the patch description that
on !res condition the driver will now return -EINVAL (instead of
-ENODEV) and print an error.

> Signed-off-by: Enrico Weigelt, metux IT consult <info@...ux.net>

Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
>  drivers/ata/sata_gemini.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/ata/sata_gemini.c b/drivers/ata/sata_gemini.c
> index f793564..55e2689 100644
> --- a/drivers/ata/sata_gemini.c
> +++ b/drivers/ata/sata_gemini.c
> @@ -318,7 +318,6 @@ static int gemini_sata_probe(struct platform_device *pdev)
>  	struct device_node *np = dev->of_node;
>  	struct sata_gemini *sg;
>  	struct regmap *map;
> -	struct resource *res;
>  	enum gemini_muxmode muxmode;
>  	u32 gmode;
>  	u32 gmask;
> @@ -329,11 +328,7 @@ static int gemini_sata_probe(struct platform_device *pdev)
>  		return -ENOMEM;
>  	sg->dev = dev;
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	if (!res)
> -		return -ENODEV;
> -
> -	sg->base = devm_ioremap_resource(dev, res);
> +	sg->base = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(sg->base))
>  		return PTR_ERR(sg->base);