linux-kernel - Re: linux-next: Tree for Aug 19 (amdgpu)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190821160958.GH8667@mellanox.com>
Date:   Wed, 21 Aug 2019 16:10:02 +0000
From:   Jason Gunthorpe <jgg@...lanox.com>
To:     "Kuehling, Felix" <Felix.Kuehling@....com>
CC:     Stephen Rothwell <sfr@...b.auug.org.au>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: Tree for Aug 19 (amdgpu)

On Wed, Aug 21, 2019 at 03:34:12PM +0000, Kuehling, Felix wrote:
> 
> On 2019-08-20 8:36 a.m., Jason Gunthorpe wrote:
> > On Tue, Aug 20, 2019 at 11:45:54AM +1000, Stephen Rothwell wrote:
> >> Hi all,
> >>
> >> On Mon, 19 Aug 2019 18:34:41 -0700 Randy Dunlap <rdunlap@...radead.org> wrote:
> >>> On 8/19/19 2:18 AM, Stephen Rothwell wrote:
> >>>> Hi all,
> >>>>
> >>>> Changes since 20190816:
> >>>>    
> >>> on x86_64:
> >>>
> >>> ../drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c: In function ‘amdgpu_exit’:
> >>> ../drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c:1471:2: error: implicit declaration of function ‘mmu_notifier_synchronize’; did you mean ‘__sync_synchronize’? [-Werror=implicit-function-declaration]
> >>>    mmu_notifier_synchronize();
> >>>    ^~~~~~~~~~~~~~~~~~~~~~~~
> >>>    __sync_synchronize
> >>>
> >>>
> >>> Full randconfig file is attached.
> >> Caused by commit
> >>
> >>    6832c9dc8358 ("hmm: use mmu_notifier_get/put for 'struct hmm'")
> >>
> >> from the hmm tree.
> >>
> >> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c need to include linux/mmu_notifier.h
> > Ah yes, thanks, it is because of !CONFIG_HMM_MIRROR in this
> > randconfig. I've fixed it up.
> 
> Thanks Jason. I'm trying to follow what's going on here, but I can't 
> find the commit hash quoted above in any of the public repositories I'm 
> tracking

I was able to squash the one line fix, so the commit ID is gone, it is
now:

https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?h=hmm&id=c7d8b7824ff9de866a356e1892dbe9f191aa5d06

From

https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/log/?h=hmm

Jason