linux-kernel - Re: [PATCH] selftests/kvm: make platform_info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a7c2qz1x.fsf@vitty.brq.redhat.com>
Date:   Wed, 21 Aug 2019 18:10:50 +0200
From:   Vitaly Kuznetsov <vkuznets@...hat.com>
To:     kvm@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>
Subject: Re: [PATCH] selftests/kvm: make platform_info_test pass on AMD

Vitaly Kuznetsov <vkuznets@...hat.com> writes:

> test_msr_platform_info_disabled() generates EXIT_SHUTDOWN but VMCB state
> is undefined after that so an attempt to launch this guest again from
> test_msr_platform_info_enabled() fails. Reorder the tests to make test
> pass.
>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@...hat.com>
> ---
>  tools/testing/selftests/kvm/x86_64/platform_info_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/kvm/x86_64/platform_info_test.c b/tools/testing/selftests/kvm/x86_64/platform_info_test.c
> index 40050e44ec0a..f9334bd3cce9 100644
> --- a/tools/testing/selftests/kvm/x86_64/platform_info_test.c
> +++ b/tools/testing/selftests/kvm/x86_64/platform_info_test.c
> @@ -99,8 +99,8 @@ int main(int argc, char *argv[])
>  	msr_platform_info = vcpu_get_msr(vm, VCPU_ID, MSR_PLATFORM_INFO);
>  	vcpu_set_msr(vm, VCPU_ID, MSR_PLATFORM_INFO,
>  		msr_platform_info | MSR_PLATFORM_INFO_MAX_TURBO_RATIO);
> -	test_msr_platform_info_disabled(vm);
>  	test_msr_platform_info_enabled(vm);
> +	test_msr_platform_info_disabled(vm);
>  	vcpu_set_msr(vm, VCPU_ID, MSR_PLATFORM_INFO, msr_platform_info);
>  
>  	kvm_vm_free(vm);

Ping!

-- 
Vitaly