linux-kernel - Re: [PATCH v2 4/4] clk: qcom: clk-rpmh: Add support for SM8150

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190822140134.GQ12733@vkoul-mobl.Dlink>
Date:   Thu, 22 Aug 2019 19:31:34 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Stephen Boyd <sboyd@...nel.org>, linux-arm-msm@...r.kernel.org,
        Andy Gross <agross@...nel.org>,
        Michael Turquette <mturquette@...libre.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/4] clk: qcom: clk-rpmh: Add support for SM8150

On 19-08-19, 22:09, Bjorn Andersson wrote:
> On Mon 19 Aug 00:39 PDT 2019, Vinod Koul wrote:
> > +static const struct clk_rpmh_desc clk_rpmh_sm8150 = {
> > +	.clks = sm8150_rpmh_clocks,
> > +	.num_clks = ARRAY_SIZE(sm8150_rpmh_clocks),
> > +};
> 
> Maybe an empty line here?

Sounds better

> 
> >  static struct clk_hw *of_clk_rpmh_hw_get(struct of_phandle_args *clkspec,
> >  					 void *data)
> >  {
> > @@ -453,6 +479,7 @@ static int clk_rpmh_probe(struct platform_device *pdev)
> >  
> >  static const struct of_device_id clk_rpmh_match_table[] = {
> >  	{ .compatible = "qcom,sdm845-rpmh-clk", .data = &clk_rpmh_sdm845},
> > +	{ .compatible = "qcom,sm8150-rpmh-clk", .data = &clk_rpmh_sm8150},
> >  	{ }
> >  };
> >  MODULE_DEVICE_TABLE(of, clk_rpmh_match_table);
> 
> Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Thanks for the review, will send an update.

-- 
~Vinod