linux-kernel - Re: [PATCH v2] net: fix skb use after free in netpoll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190825.232003.1145950065287854577.davem@davemloft.net>
Date:   Sun, 25 Aug 2019 23:20:03 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     loyou85@...il.com
Cc:     edumazet@...gle.com, dsterba@...e.com, dbanerje@...mai.com,
        fw@...len.de, davej@...emonkey.org.uk, tglx@...utronix.de,
        matwey@....msu.ru, sakari.ailus@...ux.intel.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        xiaojunzhao141@...il.com
Subject: Re: [PATCH v2] net: fix skb use after free in netpoll

From: Feng Sun <loyou85@...il.com>
Date: Mon, 26 Aug 2019 14:13:40 +0800

> +static inline bool netpoll_xmit_complete(int rc)
> +{
> +	return dev_xmit_complete(rc);
> +}

There is no need for this useless indirection, just call dev_xmit_complete()
staright.

Also, even if it was suitable, never use the inline keyword in foo.c files.