linux-kernel - Re: [PATCH v3] powerpc/fadump: sysfs for fadump memory reservation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <f53e4cfe-57cb-d8a6-385a-fa6243940573@linux.ibm.com>
Date:   Mon, 26 Aug 2019 16:14:40 +0530
From:   Sourabh Jain <sourabhjain@...ux.ibm.com>
To:     Hari Bathini <hbathini@...ux.ibm.com>, mpe@...erman.id.au
Cc:     mahesh@...ux.vnet.ibm.com, corbet@....net,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        linux-doc@...r.kernel.org
Subject: Re: [PATCH v3] powerpc/fadump: sysfs for fadump memory reservation



On 8/26/19 3:46 PM, Sourabh Jain wrote:
> 
> 
> On 8/26/19 3:29 PM, Hari Bathini wrote:
>>
>>
>> On 10/08/19 11:29 PM, Sourabh Jain wrote:
>>> Add a sys interface to allow querying the memory reserved by
>>> fadump for saving the crash dump.
>>>
>>> Add an ABI doc entry for new sysfs interface.
>>>    - /sys/kernel/fadump_mem_reserved
>>>
>>> Signed-off-by: Sourabh Jain <sourabhjain@...ux.ibm.com>
>>> ---
>>> Changelog:
>>> v1 -> v2:
>>>   - Added ABI doc for new sysfs interface.
>>>
>>> v2 -> v3:
>>>   - Updated the ABI documentation.
>>> ---
>>>
>>>  Documentation/ABI/testing/sysfs-kernel-fadump    |  6 ++++++
>>
>> Shouldn't this be Documentation/ABI/testing/sysfs-kernel-fadump_mem_reserved?

How about documenting fadump_mem_reserved and other sysfs attributes suggested
by you in a single file Documentation/ABI/testing/sysfs-kernel-fadump?
 
>>
>>> +++ b/Documentation/ABI/testing/sysfs-kernel-fadump
>>> @@ -0,0 +1,6 @@
>>> +What:		/sys/kernel/fadump_mem_reserved
>>> +Date:		August 2019
>>> +Contact:	linuxppc-dev@...ts.ozlabs.org
>>> +Description:	read only
>>> +		Provide information about the amount of memory
>>> +		reserved by fadump to save the crash dump.
>>
>> Split this up into a separate patch and have ABI documentation for
>> fadump_reserved & fadump_registered as well..

- Sourabh Jain