linux-kernel - Re: [PATCH v3] powerpc/fadump: sysfs for fadump memory reservation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <f8e9cbdd-1926-081d-c8e6-f9d55408fe51@linux.ibm.com>
Date:   Mon, 26 Aug 2019 16:46:18 +0530
From:   Hari Bathini <hbathini@...ux.ibm.com>
To:     Sourabh Jain <sourabhjain@...ux.ibm.com>, mpe@...erman.id.au
Cc:     mahesh@...ux.vnet.ibm.com, linux-doc@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        corbet@....net
Subject: Re: [PATCH v3] powerpc/fadump: sysfs for fadump memory reservation



On 26/08/19 4:14 PM, Sourabh Jain wrote:
> 
> 
> On 8/26/19 3:46 PM, Sourabh Jain wrote:
>>
>>
>> On 8/26/19 3:29 PM, Hari Bathini wrote:
>>>
>>>
>>> On 10/08/19 11:29 PM, Sourabh Jain wrote:
>>>> Add a sys interface to allow querying the memory reserved by
>>>> fadump for saving the crash dump.
>>>>
>>>> Add an ABI doc entry for new sysfs interface.
>>>>    - /sys/kernel/fadump_mem_reserved
>>>>
>>>> Signed-off-by: Sourabh Jain <sourabhjain@...ux.ibm.com>
>>>> ---
>>>> Changelog:
>>>> v1 -> v2:
>>>>   - Added ABI doc for new sysfs interface.
>>>>
>>>> v2 -> v3:
>>>>   - Updated the ABI documentation.
>>>> ---
>>>>
>>>>  Documentation/ABI/testing/sysfs-kernel-fadump    |  6 ++++++
>>>
>>> Shouldn't this be Documentation/ABI/testing/sysfs-kernel-fadump_mem_reserved?
> 
> How about documenting fadump_mem_reserved and other sysfs attributes suggested
> by you in a single file Documentation/ABI/testing/sysfs-kernel-fadump?

I wouldn't mind that but please do check if it is breaking a convention..

- Hari