linux-kernel - Re: [PATCH] cdrom: make debug logging rely on pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHcsgXTDoVGPhGg+wkcu4CYDxyRMc8+wzUZ_qbJ-L6EomkRN6g@mail.gmail.com>
Date:   Mon, 26 Aug 2019 15:51:53 +0100
From:   Diego Elio Pettenò <flameeyes@...meeyes.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Jens Axboe <axboe@...nel.dk>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cdrom: make debug logging rely on pr_debug and debugfs only.

On Sun, Aug 25, 2019 at 11:13 PM Joe Perches <joe@...ches.com> wrote:
> > -     cd_dbg(CD_OPEN, "entering register_cdrom\n");
> > +     pr_debug("entering register_cdrom\n");
>
> debut output for function tracing can also be removed
> and ftrace used instead.

Oh, nice! I have never had to go this deep into a driver before, so
I'm pretty much an ftrace noob, but that pointer actually made the
whole debugging _much_ easier, too!

I'll send an updated patch series now that (thanks to that!) I managed
to make the device I'm fighting with work.