linux-kernel - Re: [PATCH v5 1/4] dt-bindings: EDAC: Add Amazon's Annapurna Labs L1 EDAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1d23d7c5-cd7b-1512-5300-d43e82ba6dc1@amazon.com>
Date:   Mon, 26 Aug 2019 17:49:11 +0300
From:   "Hawa, Hanna" <hhhawa@...zon.com>
To:     Rob Herring <robh@...nel.org>
CC:     <mark.rutland@....com>, <bp@...en8.de>, <mchehab@...nel.org>,
        <james.morse@....com>, <davem@...emloft.net>,
        <gregkh@...uxfoundation.org>, <linus.walleij@...aro.org>,
        <Jonathan.Cameron@...wei.com>, <nicolas.ferre@...rochip.com>,
        <paulmck@...ux.ibm.com>, <dwmw@...zon.co.uk>, <benh@...zon.com>,
        <ronenk@...zon.com>, <talel@...zon.com>, <jonnyc@...zon.com>,
        <hanochu@...zon.com>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-edac@...r.kernel.org>
Subject: Re: [PATCH v5 1/4] dt-bindings: EDAC: Add Amazon's Annapurna Labs L1
 EDAC



On 8/21/2019 10:17 PM, Rob Herring wrote:
> Why is this even in DT? AFAICT, this is all just CortexA57 core features
> (i.e. nothing Amazon specific). The core type and the ECC capabilities
> are discoverable.

Added to the DT in order to easily enable/disable the driver. You are 
correct that they are CortexA57 core features and nothing Amazon 
specific, but it's IMPLEMENTATION DEFINED, meaning that in different 
cortex revisions (e.g. A57) the register bitmap may change. Because of 
that we added an Amazon compatible which corresponds to the specific 
core we are using.

Thanks,
Hanna

> 
> Rob