linux-kernel - Re: [patch V2 38/38] posix-cpu-timers: Utilize timerqueue for storage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1908271545070.1939@nanos.tec.linutronix.de>
Date:   Tue, 27 Aug 2019 15:46:00 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Frederic Weisbecker <frederic@...nel.org>
cc:     LKML <linux-kernel@...r.kernel.org>,
        Oleg Nesterov <oleg@...hat.com>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        John Stultz <john.stultz@...aro.org>,
        Anna-Maria Behnsen <anna-maria@...utronix.de>,
        Christoph Hellwig <hch@....de>
Subject: Re: [patch V2 38/38] posix-cpu-timers: Utilize timerqueue for
 storage

On Tue, 27 Aug 2019, Frederic Weisbecker wrote:
> On Tue, Aug 27, 2019 at 08:08:06AM +0200, Thomas Gleixner wrote:
> > On Tue, 27 Aug 2019, Frederic Weisbecker wrote:
> > 
> > > On Wed, Aug 21, 2019 at 09:09:25PM +0200, Thomas Gleixner wrote:
> > > >  /**
> > > > @@ -92,14 +130,10 @@ struct posix_cputimers {
> > > >  
> > > >  static inline void posix_cputimers_init(struct posix_cputimers *pct)
> > > >  {
> > > > -	pct->timers_active = 0;
> > > > -	pct->expiry_active = 0;
> > > 
> > > No more need to initialize these?
> > > 
> > > > +	memset(pct->bases, 0, sizeof(pct->bases));
> > 
> > memset() does that IIRC :)
> 
> But those two fields aren't part of pct->bases, are they? :)

Duh. I wanted to memset() the full pile obviously.